ECS chapter for new book #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Book structure
No need for example on main page
The omission of States and system ordering is deliberate to keep the example simple. It would be nice to provide feedback about the key pressed, but no clean mapping to string exists due to different keybindings.
Nilirad
suggested changes
Jun 29, 2021
MinerSebas
reviewed
Jun 29, 2021
|
@MinerSebas I think this PR involves more files than it should, probably because @alice-i-cecile included the commit "Book structure" (252325d) |
|
I think the problem is more that this targets the |
ghost
mentioned this pull request
|
Enabled the anchor links for the ECS section in alice-i-cecile#4. |
Enable anchor links in ECS section
alice-i-cecile
added a commit
to alice-i-cecile/bevy-website
that referenced
this pull request
Mar 14, 2022
alice-i-cecile
added a commit
to alice-i-cecile/bevy-website
that referenced
this pull request
Mar 14, 2022
alice-i-cecile
added a commit
to alice-i-cecile/bevy-website
that referenced
this pull request
Mar 14, 2022
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2022
I intend to close and split #182 to improve both development and review workflows. This is a tiny PR to make reviewing that work less painful by reducing weird branch issues.
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2022
I intend to close and split #182 to improve both development and review workflows. This is a tiny PR to make reviewing that work less painful by reducing weird branch issues.
This was referenced Mar 14, 2022
|
Closing this out in favor of the small, split PRs linked above. Working with all of the changes in a single PR is incredibly unwieldy as both an author and reviewer. |
|
Any plans to localize Bevy Book? |
|
@C-BJ personally yes, but once it's significantly more stable. I don't think it makes sense until 1.0. |
|
Maybe #265 description can be updated to list the PRs? |
As an alternative, I'd advocate for setting up a project board instead of trying to use a tracking issue that needs to be manually kept in sync |
ebiggs
reviewed
Mar 29, 2022
| fn end_combat_system(query: Query<Entity, (With<Combatant>, With<InCombat>>, mut commands: Commands){ | ||
| for entity in query.iter(){ | ||
| // The component will be removed at the end of the current stage | ||
| commands.entity(entity).remove(InCombat); |
There was a problem hiding this comment.
should this be remove::<InCombat>() ?
bors bot
pushed a commit
that referenced
this pull request
May 10, 2022
Extracted from #182. # Status - [x] Simplify example - [x] Avoid database analogy - [x] Edit and revise for clarity and quality - [x] Fix dead links - [x] Refactor Breakout example on Bevy repo - [x] Update text to sync closely with Breakout example
bors bot
pushed a commit
that referenced
this pull request
May 14, 2022
Ported from #182. # Status - [x] revisit and revise - [x] remove all use of direct world APIs - [x] distinguish between `Entity` type and entity concept
bors bot
pushed a commit
that referenced
this pull request
May 14, 2022
Ported from #182. # Status - [x] revisit and revise - [x] remove all use of direct world APIs - [x] distinguish between `Entity` type and entity concept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you'd like to read (or review) this PR, you'll need to:
zola serve --openfrom that directory.To do:
WorldCellfrom this chapter.