Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Checkout commit from forked repo #393

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mboutet
Copy link
Contributor

@mboutet mboutet commented Nov 12, 2023

Possible fix for #392

@@ -14,7 +14,7 @@ message(STATUS "FetchContent from branch: ${RYML_BRANCH_NAME}")

include(FetchContent)
FetchContent_Declare(ryml
GIT_REPOSITORY https://github.com/biojppm/rapidyaml.git
GIT_REPOSITORY https://github.com/${PULL_REQUEST_HEAD_REPO:biojppm/rapidyaml}.git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with Make's syntax, so feel free to edit. I want to use PULL_REQUEST_HEAD_REPO and fallback to biojppm/rapidyaml if PULL_REQUEST_HEAD_REPO is not set.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mboutet mboutet marked this pull request as ready for review November 12, 2023 17:16
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #393 (60aa4da) into master (2cf09b0) will not change coverage.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files          22       22           
  Lines        8155     8155           
=======================================
  Hits         7877     7877           
  Misses        278      278           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@biojppm biojppm force-pushed the master branch 4 times, most recently from d128813 to 507400e Compare April 16, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants