Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartapi test #31

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Smartapi test #31

wants to merge 6 commits into from

Conversation

rjawesome
Copy link
Contributor

@tokebe
Copy link
Member

tokebe commented Jun 25, 2024

From the looks of the implementation, an exception is captured in Sentry for the whole thing failing. It's preferable to create an individual Sentry exception whenever a given KP fails, with specifics of the criteria it failed (spec for expected API doesn't exist, API is unreachable, test example fails). This can be a totally artificial exception.

@rjawesome
Copy link
Contributor Author

@tokebe Done.
ex.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants