Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set JDK version to 21 #444

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Set JDK version to 21 #444

wants to merge 1 commit into from

Conversation

ArnyminerZ
Copy link
Member

Purpose

Required by KSP, we have to increase the compatibility level to JDK 21.

Short description

Changed JSK level from 17 to 21

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ ArnyminerZ added the refactoring Quality improvement of existing functions label Oct 3, 2024
@ArnyminerZ ArnyminerZ requested a review from sunkup October 3, 2024 14:42
@ArnyminerZ ArnyminerZ self-assigned this Oct 3, 2024
@ArnyminerZ ArnyminerZ marked this pull request as ready for review October 3, 2024 14:42
@ArnyminerZ ArnyminerZ marked this pull request as draft October 3, 2024 14:47
@ArnyminerZ ArnyminerZ removed the request for review from sunkup October 3, 2024 14:47
@sunkup
Copy link
Member

sunkup commented Nov 18, 2024

What is the state of this PR? It seems to build fine for me locally with VERSION_21 on the up-to-date dev branch ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Quality improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants