-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/etcd] Fixing defrag etcd for authenticated and tls clusters #30096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bled clusters We don't have an easy way to generate jwt tokens so for now it only works with .Values.auth.token.type = "simple". Signed-off-by: Miguel Sacristán Izcue <[email protected]>
…g cron job Signed-off-by: Miguel Sacristán Izcue <[email protected]>
tete17
changed the title
[bitnami/etcd]: Fixing defrag etcd for authenticated and tls clusters
[bitnami/etcd] Fixing defrag etcd for authenticated and tls clusters
Oct 27, 2024
tete17
force-pushed
the
Fixing-defrag-etcd
branch
from
October 27, 2024 20:01
6b68ecb
to
5354e69
Compare
4 tasks
Signed-off-by: Bitnami Containers <[email protected]>
javsalgar
added
verify
Execute verification workflow for these changes
in-progress
labels
Oct 28, 2024
Signed-off-by: Bitnami Containers <[email protected]>
dgomezleon
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for contributing!
4 tasks
shreekumar2901
pushed a commit
to EoWal/charts
that referenced
this pull request
Nov 5, 2024
…itnami#30096) * fix(etcd): Fix defragmentation cronjob to work with authenticated enabled clusters We don't have an easy way to generate jwt tokens so for now it only works with .Values.auth.token.type = "simple". Signed-off-by: Miguel Sacristán Izcue <[email protected]> * fix(etcd): Support the usage of client secure transport for the defrag cron job Signed-off-by: Miguel Sacristán Izcue <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Miguel Sacristán Izcue <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Co-authored-by: Bitnami Containers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixing the etcd defrag cron job for:
Benefits
It fixes a feature for a specific usage of the chart
Possible drawbacks
Nothing obvious
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm