Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/etcd] Fixing defrag etcd for authenticated and tls clusters #30096

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

tete17
Copy link
Contributor

@tete17 tete17 commented Oct 27, 2024

Description of the change

Fixing the etcd defrag cron job for:

  • Authenticated custers
  • TLS enabled clusters with client communicatiom

Benefits

It fixes a feature for a specific usage of the chart

Possible drawbacks

Nothing obvious

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

…bled clusters

We don't have an easy way to generate jwt tokens so for now it only works with
.Values.auth.token.type = "simple".

Signed-off-by: Miguel Sacristán Izcue <[email protected]>
@github-actions github-actions bot added etcd triage Triage is needed labels Oct 27, 2024
@tete17 tete17 changed the title [bitnami/etcd]: Fixing defrag etcd for authenticated and tls clusters [bitnami/etcd] Fixing defrag etcd for authenticated and tls clusters Oct 27, 2024
Signed-off-by: Bitnami Containers <[email protected]>
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Oct 28, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 28, 2024
@github-actions github-actions bot removed the request for review from javsalgar October 28, 2024 10:46
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@dgomezleon dgomezleon merged commit 558e971 into bitnami:main Oct 28, 2024
10 checks passed
shreekumar2901 pushed a commit to EoWal/charts that referenced this pull request Nov 5, 2024
…itnami#30096)

* fix(etcd): Fix defragmentation cronjob to work with authenticated enabled clusters

We don't have an easy way to generate jwt tokens so for now it only works with
.Values.auth.token.type = "simple".

Signed-off-by: Miguel Sacristán Izcue <[email protected]>

* fix(etcd): Support the usage of client secure transport for the defrag cron job

Signed-off-by: Miguel Sacristán Izcue <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Miguel Sacristán Izcue <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Co-authored-by: Bitnami Containers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
etcd solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants