Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change vehicle real path color #1423

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Change vehicle real path color #1423

merged 1 commit into from
Oct 31, 2024

Conversation

ArturoManzoli
Copy link
Contributor

@ArturoManzoli ArturoManzoli commented Oct 22, 2024 •
edited
Loading

Closes #1348

@ArturoManzoli ArturoManzoli changed the title 1348 change vehicle real path color Change vehicle real path color Oct 22, 2024
rafaellehmkuhl
rafaellehmkuhl requested changes Oct 26, 2024
View reviewed changes
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in the VGI brakes all the existing VGIs

image

src/assets/defaults.ts Outdated
hash: defaultBoatProfileHash,
hash: 'adb7d856-f2e5-4980-aaeb-c39c1fa3562b',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change brakes the profile auto-load functionality.

@rafaellehmkuhl
Copy link
Member

rafaellehmkuhl commented Oct 26, 2024 •
edited
Loading

@ArturoManzoli there are 3 different changes in this PR. It would be good to separate them in 3 different PRs. This also helps on changelog generation.

PS: I saw now that there's another PR with the boat profile changes. Can we just have the map changes on this one? I also repeated the review there for consistency.

@ArturoManzoli ArturoManzoli force-pushed the 1348-change-vehicle-real-path-color branch from 30b0eeb to add267f Compare October 30, 2024 15:59
@ArturoManzoli
Copy link
Contributor Author

@ArturoManzoli there are 3 different changes in this PR. It would be good to separate them in 3 different PRs. This also helps on changelog generation.

PS: I saw now that there's another PR with the boat profile changes. Can we just have the map changes on this one? I also repeated the review there for consistency.

Yep, my bad. Just made some git mistake and brought the other PR branch here.
Fixed now

Also opening a separate PR for the Mission UI changes

rafaellehmkuhl
rafaellehmkuhl approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loved the tether cable color haha

@rafaellehmkuhl rafaellehmkuhl merged commit 6cc07ed into bluerobotics:master Oct 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaellehmkuhl rafaellehmkuhl rafaellehmkuhl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color of the vehicle real path is the same as the target path
2 participants
@ArturoManzoli @rafaellehmkuhl