specs/mst: 'left' and 'tree' fields are nullable, not optional #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @str4d for reporting!
bnewbold
added a commit
to bluesky-social/indigo
that referenced
this pull request
Sep 27, 2024
arcalinea
temporarily deployed
to
bnewbold/mst-nullable - atproto-website PR #346
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns spec with implementation and data in the network.
I think if we did this over from scratch, could make these "optional" instead to save a tiny bit of data. Maybe can change if we do a v4 iteration? But even then might not be worth the churn.
Thanks @str4d for reporting!
Closes: #312