Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use profile createdAt timestamp to determine account age #232

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

foysalit
Copy link
Contributor

No description provided.

Copy link
Contributor

@matthieusieben matthieusieben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 17 to 21
const profile = repo.relatedRecords.find(
(r) => r?.['$type'] === CollectionId.Profile,
)
return profile ? (profile as AppBskyActorProfile.Record) : null
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using the isX type utils, you should be able to avoid having to type cast here

Suggested change
const profile = repo.relatedRecords.find(
(r) => r?.['$type'] === CollectionId.Profile,
)
return profile ? (profile as AppBskyActorProfile.Record) : null
}
return repo.relatedRecords.find(AppBskyActorProfile.isRecord)
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh TIL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants