✨ Show warning for high profile accounts based on follower count #235
+68
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
approved these changes
Nov 18, 2024
| @@ -828,22 +834,37 @@ function Form( | |||
| function useSubjectQuery(subject: string) { | |||
There was a problem hiding this comment.
nit, and probably a more general comment, but I think that the get profile part would be better implemented as its own useSubjectProfile hook. This would allow for better composability and maintainability in the future.
There was a problem hiding this comment.
yeah that's fair. just don't have many places here where profile is needed in isolation so feels more natural for me to tie it to repo/record data fetcher for now at least.
| <Alert | ||
| type="warning" | ||
| title="High profile account" | ||
| body={`This user has more than ${HIGH_PROFILE_FOLLOWER_THRESHOLD} followers. Please take caution when moderating this account.`} |
There was a problem hiding this comment.
Should the actual count be displayed here (since we have the info at hand) ?
arcalinea
temporarily deployed
to
follower-count-warning - ozone-staging PR #235
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a prominently visible warning when actioning an account with follower count more than a configured value (through env var)