Add gif support to web #6433
Open
Add gif support to web #6433
+184
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozzius
requested review from
gaearon,
haileyok and
estrattonbailey
and removed request for
gaearon and
haileyok
mozzius
commented
Nov 16, 2024
| if (uri.startsWith('data:video/')) { | ||
| onSelectVideo(post.id, {uri, type: 'video', height: 0, width: 0}) | ||
| if (uri.startsWith('data:video/') || uri.startsWith('data:image/gif')) { | ||
| if (isNative) return // web only |
There was a problem hiding this comment.
is it possible to paste videos on native? do we need to handle this? it will be broken in prod anyway since the old code sets the height/width to 0
|
This comment has been minimized.
This comment has been minimized.
|
I sincerely apologize for misunderstood the meaning. |
|
All good, don't worry about it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows adding gifs on web - processed as video.
Also reimplements the video picker, since
expo-image-picker's implementation on web is absolutely terrible, does not support half the props, and does not support changing the accepted mime types. This change greatly simplifies the logic for normal videos too, since the preview no longer needs to pull double duty detecting the image dimensions or duration - this has been moved togetVideoMetadatawhich is called when the video is first picked. This can and should still be simplified further, since we're inefficiently passing dataurls around, but this is easy for now since it lets us maintain compatibility with theImagePickerAssettypeNote
I don't have a way of detecting how long a gif is (i.e. it could be not even animated, it could be >60s) so we just have to let the server reject these. Apparently it seems you can parse the bytes manually to determine this? Hopefully that's uncommon enough that we can get away with not rejecting on the client
TODO (but out of scope for this PR): different presentation for gifs. needs lexicon change.
Screen.Recording.2024-11-16.at.21.51.39.mov
Test plan