fix(payment-option): hide dibs when no previous orders #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, handout orders do _not_ produce a movedFromOrder, and thus the originalOrderIds array will be empty. Since we just check that every order is by the customer, this will return true if there are no orders. Therefore, we have to reject DIBS if there are no previous orders.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LarsSelbekk
approved these changes
Aug 25, 2023
Neh, this is just for accounting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, handout orders do not produce a movedFromOrder, and thus
the originalOrderIds array will be empty. Since we just check that every
order is by the customer, this will return true if there are no orders.
Therefore, we have to reject DIBS if there are no previous orders.