Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a merge error in unftp-sbe-fs functional tests #488

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Sep 7, 2023

PRs #474 and #473 had another merge conflict that caused runtime test failures.

PRs bolcom#474 and bolcom#473 had another merge conflict that caused runtime test
failures.
@hannesdejager
Copy link
Collaborator

Is this based on the latest master? I didn't see any test failures with the last MR.

@asomers
Copy link
Contributor Author

asomers commented Sep 7, 2023

Yes. But the test failures aren't deterministic. They happen when running the tests on a multicore system or with --test-threads > 1. If the rmd test runs at the same time as another test, it is possible that they will both try to use port 1243 at the same time, resulting in a ConnectionError for one or the other.

@hannesdejager hannesdejager merged commit 286e861 into bolcom:master Sep 7, 2023
3 checks passed
@asomers asomers deleted the merge-conflict2 branch September 7, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants