Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/stack nontrivials #948

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Feature/stack nontrivials #948

wants to merge 10 commits into from

Conversation

grisumbras
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #948 (91a7303) into develop (90d858f) will increase coverage by 0.03%.
The diff coverage is 99.06%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #948      +/-   ##
===========================================
+ Coverage    93.01%   93.04%   +0.03%     
===========================================
  Files           87       87              
  Lines         8112     8170      +58     
===========================================
+ Hits          7545     7602      +57     
- Misses         567      568       +1
Files Coverage Δ
include/boost/json/detail/stack.hpp 100.00% <100.00%> (ø)
include/boost/json/detail/impl/stack.hpp 99.00% <99.00%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90d858f...91a7303. Read the comment docs.

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

vinniefalco
vinniefalco reviewed Oct 11, 2023
View reviewed changes
include/boost/json/detail/impl/stack.hpp Outdated
*/
//--------------------------------------

struct stack::non_trivial
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awfully familiar, didn't I already do something similar?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's your code (yet). I'm trying several changes against automatic benchmarking. I want to find the variation of it that affects performance in the smallest way.

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@grisumbras grisumbras marked this pull request as ready for review November 14, 2023 09:42
@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/948/pullrequest.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinniefalco vinniefalco vinniefalco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grisumbras @cppalliance-bot @vinniefalco