Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for modular build structure. #113

Merged
merged 18 commits into from
Aug 27, 2024
Merged

Conversation

grafikrobot
Copy link
Member

@grafikrobot grafikrobot commented Jul 20, 2024

This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.

This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:

This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.

@pdimov
Copy link
Member

pdimov commented Aug 17, 2024

What's the problem with libs/functional here?

@grafikrobot
Copy link
Member Author

What's the problem with libs/functional here?

The problem is that this: https://github.com/boostorg/smart_ptr/actions/runs/10429524218/job/28887047180?pr=113#step:7:18 does not install functional. Which is needed for some of the tests.

@pdimov
Copy link
Member

pdimov commented Aug 17, 2024

Why do you think it's needed?

@pdimov
Copy link
Member

pdimov commented Aug 17, 2024

This header isn't in libs/functional.

@grafikrobot
Copy link
Member Author

This header isn't in libs/functional.

Seriously :-( After searching I see it's container_hash. So messy for the brain. I'll fix it. And the other places where this happens.

@grafikrobot grafikrobot marked this pull request as ready for review August 18, 2024 14:12
@grafikrobot
Copy link
Member Author

Please review and merge this PR at your earliest convenience.

@pdimov
Copy link
Member

pdimov commented Aug 18, 2024

This still contains a lot of unnecessary CI changes.

@grafikrobot
Copy link
Member Author

This still contains a lot of unnecessary CI changes.

Grr.. I thought I had fixed that.

@grafikrobot
Copy link
Member Author

@pdimov okay, removed them. Dealing with >150 PRs has seriously jumbled my brain at this point. :-(

@pdimov
Copy link
Member

pdimov commented Aug 18, 2024

Good thing I only need to deal with ~23 of these or so.

@pdimov pdimov merged commit 71902a7 into boostorg:develop Aug 27, 2024
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants