Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for modular build structure. #44

Merged
merged 11 commits into from
Aug 28, 2024

Conversation

grafikrobot
Copy link
Member

@grafikrobot grafikrobot commented Jul 20, 2024

This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.

This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:

This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.

test/Jamfile Outdated Show resolved Hide resolved
@pdimov
Copy link
Member

pdimov commented Jul 21, 2024

Are these dependencies actually required? I see nothing in the PR that depends on them.

Conversely, doesn't it depend on the PRs for the library dependencies being merged first? Where does e.g. /boost/mp11 come from? Although CI seems to have no problem with it for some reason.

@grafikrobot
Copy link
Member Author

Are these dependencies actually required? I see nothing in the PR that depends on them.

According to https://pdimov.github.io/boostdep-report/develop/variant2.html yes.

Conversely, doesn't it depend on the PRs for the library dependencies being merged first? Where does e.g. /boost/mp11 come from? Although CI seems to have no problem with it for some reason.

Those get created by the boost-root/jamroot as needed until the transition is fully complete. Although I missed some cases that I'll need to fix. But that was the point of creating all the PRs. To shake out all the issues.

@pdimov
Copy link
Member

pdimov commented Jul 21, 2024

build.jam Show resolved Hide resolved
build.jam Show resolved Hide resolved
@grafikrobot
Copy link
Member Author

Why would this PR depend on the tools? It seems to work as-is.

It may well not depend on them. But I can't guarantee that building docs will work for any particular library without the tools first. As most libraries do not check if their docs build in CI.

@pdimov
Copy link
Member

pdimov commented Jul 21, 2024

I don't think that build.jam should affect the docs, regardless of whether tools are updated.

(It currently does, but it shouldn't.)

@grafikrobot grafikrobot marked this pull request as ready for review August 18, 2024 15:27
@grafikrobot
Copy link
Member Author

Please review and merge this PR at your earliest convenience.

@pdimov pdimov merged commit f78343e into boostorg:develop Aug 28, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants