Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show flair for new contributors in the selected release. #1299

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

brianjp93
Copy link
Collaborator

@brianjp93 brianjp93 commented Sep 27, 2024

image
In the library detail page, if a contributor has never contributed before the selected release, give them a "new contributor" flair.

@brianjp93 brianjp93 linked an issue Sep 30, 2024 that may be closed by this pull request
Copy link
Collaborator

@rbbeeston rbbeeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks good from a coding standpoint, although I think there are some front-end decisions that are still up in the air that need some agreement. For now, can we remove the star and border, and just have the new contributors on a seperate line?

One other minor thing. the maintainer has their name under their avatar, but the name is repeated in the contributor list of names. I think for now, filter out the maintainers from the contributor names. Thanks!

@brianjp93
Copy link
Collaborator Author

image
Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"New" Avatar flair on new contributors
2 participants