-
-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --keep-all
, as an alias for '--keep-last <inf>', as an option…
#7462
base: master
Are you sure you want to change the base?
Added --keep-all
, as an alias for '--keep-last <inf>', as an option…
#7462
Conversation
… for borg-prune. Fixes borgbackup#6656
acd9654
to
e69fbe9
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #7462 +/- ##
=======================================
Coverage 83.87% 83.87%
=======================================
Files 67 67
Lines 11817 11818 +1
Branches 2155 2155
=======================================
+ Hits 9911 9912 +1
Misses 1332 1332
Partials 574 574
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hehe, looks good. Considering the special infinity value, I guess a test for this would be good (just test the code does not crash and keeps all archives present, except old checkpoint archives). |
What happens if someone does The above conflicts might happen because someone has a script that already has various |
@jdchristensen, interesting insight. I'll take a look at the interactions between those flags. @ThomasWaldmann I did test that eye-catching infinite value locally (didn't test deeply, just created a few archives to see that it didn't crash). I can write up a unit test to see how well it works with keeping archives and removing checkpoints. I would love to hear your thoughts on @jdchristensen's remarks though. |
Good catch!
Issue #6269 applies here also, I guess.
|
If we have different argparse options, we could also use this: https://docs.python.org/3/library/argparse.html#mutual-exclusion |
I resolved the merge conflict and also had another look:
@Michael-Girma Can you try to implement that and add a test? |
@Michael-Girma did you see my last comment, can you fix it? |
@ThomasWaldmann just seeing this. Will take a look tonight. |
ping. |
ping |
1 similar comment
ping |
@Michael-Girma do you need help finishing this? |
… for borg-prune. Fixes #6656
--keep-last
when pruning.