Add pydantic models for borg 1.x's CLI (#8338) #8343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-gn
commented
Aug 26, 2024
| @@ -24,9 +25,15 @@ def __init__(self, msgid=None): | |||
| self.id = self.operation_id() | |||
| self.msgid = msgid | |||
|
|
|||
| def make_json(self, *, finished=False, **kwargs): | |||
| def make_json(self, *, finished=False, override_time: typing.Optional[float] = None, **kwargs): | |||
There was a problem hiding this comment.
Let me know if you think this new argument is bad. The function is harder to test when it always takes time.time().
|
@ThomasWaldmann I just fixed the Python 3.10 union syntax, hopefully that's the last of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds pydantic models for borg's CLI outputs (fixes #8338).
Sadly I can't try to run these tests locally; when trying to run tox or
pip install borgI getOSError: pkg-config probably not installed: FileNotFoundError(2, 'No such file or directory').