Build eksctl-anywhere binary from source #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the runner size from 16 to 8. Testsys builds are not overly CPU resource constrained, so this uses the smaller runner to reduce some expense. Signed-off-by: Sean McGinnis <[email protected]>
etungsten
reviewed
Sep 7, 2023
stmcginnis
force-pushed
the
eksa-image-builds
branch
from
a06ea98
to
e8e238a
Compare
Change to a smaller runner size since the larger instance doesn't speed things up too much. Also renames the workflow so the definition file and workflow run name are in sync. Signed-off-by: Sean McGinnis <[email protected]>
Signed-off-by: Sean McGinnis <[email protected]>
stmcginnis
force-pushed
the
eksa-image-builds
branch
from
e8e238a
to
9440c21
Compare
etungsten
reviewed
Sep 7, 2023
GitHub Action runners do not provide a TTY. This results in errors when running `make tools` in the CI checks: ``` ERROR: failed to get console: provided file is not a console ``` This switches the `docker build` argument over to use `plain` instad of `tty` to avoid this error. Signed-off-by: Sean McGinnis <[email protected]>
Signed-off-by: Sean McGinnis <[email protected]>
Signed-off-by: Sean McGinnis <[email protected]>
Signed-off-by: Sean McGinnis <[email protected]>
Existing method gets eksctl-anywhere by curling the binary of a specific release version. Base functionality is fairly stable, and we often need to pick up the latest when adding a new variant to get support for a newer k8s version. That is the case now with needing the k8s 1.28 support that is not in a release yet. Signed-off-by: Sean McGinnis <[email protected]>
stmcginnis
force-pushed
the
eksa-image-builds
branch
from
9440c21
to
ee29a86
Compare
|
Build now passing, with the exception of the existing failure for the |
|
What's going on with the CI failures for --offline? |
I don't know, I've asked that on several PRs over the last month or two, but no one has given a good answer. I tried digging in a little, but I was not able to figure out what changed to cause this to start happening. My guess it is either due to a change in the SDK or a change in the newer versions of the Rust toolchain used. It seems like something isn't getting mounted in the right place for the |
arnaldo2792
approved these changes
Sep 8, 2023
etungsten
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Existing method gets eksctl-anywhere by curling the binary of a specific release version. Base functionality is fairly stable, and we often need to pick up the latest when adding a new variant to get support for a newer k8s version. That is the case now with needing the k8s 1.28 support that is not in a release yet.
Testing done:
Ran
make images, built with no error.Cleaned up caching and run
make images -e TESTSYS_EKSA_REF=heads/mainto pick up the latesteksctl-anywherefrommain.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.