Fix CI build to unblock dependabots #659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fix the CI to unblock PRs:
#658
#657
#656
#654
Description of changes:
I am seeing build failures when running
make build
with the latest rustc version (rustup update stable
to update).Failure 1: Starting with Rust 1.80 (or nightly-2024-05-05) every reachable
#[cfg]
will be automatically checked that they match the expected config names and values. See more details in this blog.Our CI build failed with
One way to fix it is to add the lints table in
Cargo.toml
.But we are using
feature = "mockall"
everywhere else, so making the change for consistency.Failure 2: Also with the Rust 1.80 release, there is another linter error
clippy::needless_borrows_for_generic_args
(See more details here).Testing done:
make build
passed.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.