fix(metadata-sidebar): Fix metadata sidebar ai capabilities

[jankowiakdawid]

Fix from where we read if Metadata Sidebar should have AI capabilities turned on.

Screenshots

[greg-in-a-box]

is isFeatureEnabled doing what useFeatureEnabled is doing? do we need both?

[jankowiakdawid]

No I don't think so.

useFeatureEnabled is checking the features array. In our case we can check if metadata redesign is enabled, or if metadata aiSuggestions are enabled.

isFeatureEnabled is a prop that comes from host application in metadataSidebarProps

box-ui-elements/src/elements/content-sidebar/SidebarPanels.js

Line 61 in 549188a

metadataSidebarProps: MetadataSidebarProps,

it's defined here

box-ui-elements/src/elements/content-sidebar/MetadataSidebar.js

Lines 43 to 47 in 549188a

	type ExternalProps = {
	isFeatureEnabled: boolean,
	selectedTemplateKey?: string,
	templateFilters?: Array<string> | string,
	};

maybe @bfoxx1906 or @jstoffan have more insight if it should be used 🤔

[JChan106]

Took a look, useFeatureEnabled isn't used anywhere else in BUIE. However, Seems like a use case for components that don't have the features array passed down, so it probably is needed here. Have we tested useFeatureEnabled works as expected here?

[jankowiakdawid]

Yes, useFeatureEnabled works as expected. It's covered with a storybook story test (also in this PR). It was recommended by @jstoffan some time ago.

Now after re-reading this I understand initial confusion. As I mentioned isFeatereEnalbed is a prop indicating if user has Metadata Sidebar enabled for them.