chore(content-explorer): Migrate deleteConfirmationDialog #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-in-a-box
force-pushed
the
deletedialog
branch
from
05102e1
to
59e4c49
Compare
tjuanitas
reviewed
Oct 7, 2024
| <Modal onOpenChange={onCancel} open={isOpen}> | ||
| <Modal.Content | ||
| aria-label={formatMessage(messages.deleteDialogLabel)} | ||
| className="bce-DeleteConfirmationDialog" |
Comment on lines
20
to
25
| isOpen, | ||
| onDelete, | ||
| onCancel, | ||
| item, | ||
| isLoading, | ||
| parentElement, |
Comment on lines
51
to
53
| </Modal.Footer> | ||
| </Modal.Content> |
There was a problem hiding this comment.
the rename dialog also includes a close button, do we need it here?
There was a problem hiding this comment.
when the modal is opened, what is the element that is focused?
There was a problem hiding this comment.
close is focused, confirmed by hitting enter and a console.log after its open
greg-in-a-box
force-pushed
the
deletedialog
branch
from
59e4c49
to
f09447c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after