revert(content-explorer): Revert rename dialog #3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjiang-box
changed the title
greg-in-a-box
approved these changes
Oct 8, 2024
tjuanitas
approved these changes
Oct 8, 2024
greg-in-a-box
pushed a commit
to DanilaRubleuski/box-ui-elements
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #3666
Context:
The blueprint's Modal behaves differently than react-modal when there are multiple elements such as contentExplorer in one page. The blueprint's Modal will give
aria-label: hiddento all the elements besides the modal which means you are unable to interact with other elements in current webpage once the modal in that single content-explorer element opens.After discussion with @tjuanitas and @greg-in-a-box , we decide to revert the rename dialog first and migrate components besides the modal to the blueprint.