fix: resolve missing exports for esbuild #3719
Open
+10
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjuanitas
commented
Oct 17, 2024
| import type { BoxItem } from '../common/types/core'; | ||
| import { ERROR_CODE_EXTRACT_STRUCTURED } from '../constants'; | ||
| import { isUserCorrectableError } from '../utils/error'; | ||
| import type { QuestionType } from '@box/box-ai-content-answers'; |
There was a problem hiding this comment.
eslint is forcing import order during pre-commit hook
jpan-box
approved these changes
Oct 17, 2024
tjiang-box
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite apps that install box-ui-elements hit the following errors:
two issues:
typeis needed in the import statement so that during theesbuild step, these lines are properly removedWithAnnotationsPropsandWithAnnotatorContextPropswere not exported in theindex.tswhen ContentPreview is trying to import from that file