Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache for cellfinder workflow tests #102

Merged
merged 3 commits into from
May 1, 2024

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Apr 30, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
We are trying to speed up tests in CI. This PR adds a cache for the cellfinder workflow tests that run in CI.

What does this PR do?
Adds a cache step to the test job that runs in CI.

References

#65

How has this PR been tested?

Checks for this PR should pass.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No.

Checklist:

  • [ n/a] The code has been tested locally
  • [ n/a] Tests have been added to cover all new functionality (unit & integration)
  • [ n/a] The documentation has been updated to reflect any changes
  • [ x] The code has been formatted with pre-commit

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (b5f62ef) to head (2a7873c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   79.38%   84.45%   +5.06%     
==========================================
  Files          18       17       -1     
  Lines         917      862      -55     
==========================================
  Hits          728      728              
+ Misses        189      134      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig marked this pull request as ready for review April 30, 2024 14:44
@sfmig sfmig requested a review from a team April 30, 2024 14:44
@adamltyson
Copy link
Member

@sfmig, naively, shouldn't this speed up the tests?

@sfmig
Copy link
Contributor Author

sfmig commented Apr 30, 2024

@adamltyson yeah I was expecting at least a few minutes of improvement, but it seems I didn't implement it correctly. Will revert to draft.

@sfmig sfmig marked this pull request as draft April 30, 2024 16:06
@sfmig sfmig removed the request for review from a team April 30, 2024 16:07
@sfmig sfmig requested a review from a team April 30, 2024 17:33
@sfmig sfmig marked this pull request as ready for review April 30, 2024 17:33
@adamltyson adamltyson merged commit 62a61b1 into main May 1, 2024
11 checks passed
@adamltyson adamltyson deleted the smg/cache-cellfinder-workflow-data branch May 1, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants