Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fetchPaymentMethodNonces #1464

Open
wants to merge 4 commits into
base: v7
Choose a base branch
from
Open

Remove fetchPaymentMethodNonces #1464

wants to merge 4 commits into from

Conversation

stechiu
Copy link
Collaborator

@stechiu stechiu commented Nov 12, 2024

Summary of changes

  • Removed both the async and completion fetchPaymentMethodNonces methods
  • Removed any associated classes that are no longer needed
  • We do not need to move this method to the Drop-in on iOS as it is not currently being maintained

Remove all tests that reference fetchPaymentMethodNonces

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@stechiu stechiu requested a review from a team as a code owner November 12, 2024 23:27
jaxdesmarais
jaxdesmarais reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe with this we should also be able to remove BTPaymentMethodNonceParser

jaxdesmarais
jaxdesmarais reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a changelog for removing this method and the parser since they are both public. Other than that looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stechiu @jaxdesmarais