Merge pull request #92 from ahonymous/bugfix/not-found-messenger-tran…

…sports-with-empty-config bugfix: Set up empty messenger.transports parameter
brefphp · Aug 16, 2024 · f0cfa51 · f0cfa51
2 parents 872562e + b73aa8c
commit f0cfa51
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 42 deletions.
diff --git a/src/DependencyInjection/BrefMessengerExtension.php b/src/DependencyInjection/BrefMessengerExtension.php
@@ -21,9 +21,7 @@ public function prepend(ContainerBuilder $container): void
         $frameworkConfig = $container->getExtensionConfig('framework');
         $messengerTransports = $this->getMessengerTransports($frameworkConfig);
 
-        if (! empty($messengerTransports)) {
-            $container->setParameter('messenger.transports', $messengerTransports);
-        }
+        $container->setParameter('messenger.transports', $messengerTransports);
     }
 
     private function getMessengerTransports(array $frameworkConfig): array

diff --git a/tests/Unit/DependencyInjection/BrefMessengerExtensionTest.php b/tests/Unit/DependencyInjection/BrefMessengerExtensionTest.php
@@ -210,52 +210,28 @@ public function providePrependSetsMessengerTransportsParameterCases(): iterable
                 ],
             ],
         ];
-    }
-
-    /**
-     * @dataProvider provideDoesNotSetMessengerTransportsParameterCases
-     */
-    public function testPrependDoesNotSetMessengerTransportsParameterWhenNoMessengerConfigExists(
-        array $config,
-    ): void {
-        $container = self::createMock(ContainerBuilder::class);
-        $container->method('getExtensionConfig')
-            ->with('framework')
-            ->willReturn($config);
-
-        $container->expects(self::never())->method('setParameter');
 
-        $extension = new BrefMessengerExtension;
-        $extension->prepend($container);
-    }
-
-    public function provideDoesNotSetMessengerTransportsParameterCases(): iterable
-    {
-        yield 'empty config' => [
-            'config' => [],
-        ];
-
-        yield 'empty messenger config' => [
-            'config' => [
-                'messenger' => [],
-            ],
-        ];
-
-        yield 'not empty messenger config without transports key' => [
-            'config' => [
-                'messenger' => [
-                    'busses' => [],
+        yield 'empty transports config when messenger only consuming messages' => [
+            'existConfig' => [
+                [
+                    'messenger' => [
+                        'transports' => [],
+                    ],
                 ],
             ],
+            'expectedTransportsParameter' => [],
         ];
 
-        yield 'not empty messenger config with empty transports key' => [
-            'config' => [
-                'messenger' => [
-                    'transports' => [],
-                    'busses' => [],
+        yield 'multiple messenger configs with empty transports key when messenger only consuming messages' => [
+            'existConfig' => [
+                [
+                    'messenger' => [
+                        'transports' => [],
+                        'busses' => [],
+                    ],
                 ],
             ],
+            'expectedTransportsParameter' => [],
         ];
     }
 }