Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-927 Quieter progress on GCP Batch #7563

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,6 @@ class GcpBatchAsyncBackendJobExecutionActor(override val standardParams: Standar

for {
_ <- Future.unit // trick to get into a future context
_ = log.info(s"started polling for $jobNameStr")
jobName = JobName.parse(jobNameStr)
status <- pollStatus(workflowId, jobName, backendSingletonActor, initializationData.requestFactory)
} yield status
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ object BatchRequestExecutor {

def execute(groupedRequests: GcpBatchGroupedRequests)(implicit ec: ExecutionContext): Future[List[Try[Unit]]] = {
val requests = groupedRequests.entries
logger.info(s"Execute ${requests.size} requests")

if (requests.isEmpty) Future.successful(List.empty)
else nonEmptyExecute(requests)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ trait GetRequestHandler extends LazyLogging { this: RequestHandler =>
val _ = resultF
.map {
case Success(BatchApiResponse.StatusQueried(status)) =>
logger.info(s"Get operation succeeded for ${pollRequest.jobId.jobId}: $status")
pollRequest.requester ! status
Success(())

Expand Down
Loading