Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vapor 4 #43

Open
wants to merge 72 commits into
base: master
Choose a base branch
from
Open

Vapor 4 #43

wants to merge 72 commits into from

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Mar 27, 2020

TODO:

  • README
  • Tests
  • Migrate test methods to new throwing ones

@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #43 (376f57f) into master (56851f4) will decrease coverage by 2.36%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   86.47%   84.10%   -2.37%     
==========================================
  Files          37       44       +7     
  Lines        1153     1271     +118     
==========================================
+ Hits          997     1069      +72     
- Misses        156      202      +46     
Impacted Files Coverage Δ
...ces/SteamPress/Presenters/BlogAdminPresenter.swift 0.00% <0.00%> (ø)
Sources/SteamPress/Presenters/BlogPresenter.swift 0.00% <0.00%> (ø)
...es/SteamPress/Services/LongPostDateFormatter.swift 100.00% <ø> (ø)
...ces/SteamPress/Services/NumericPostFormatter.swift 100.00% <ø> (ø)
Sources/SteamPress/SteamPressError.swift 100.00% <ø> (ø)
Sources/SteamPress/Views/PaginatorTag.swift 0.00% <0.00%> (ø)
...sitories/Application+SteamPress+Repositories.swift 62.85% <62.85%> (ø)
...rces/SteamPress/Presenters/ViewBlogPresenter.swift 86.25% <68.18%> (-0.85%) ⬇️
...rces/SteamPress/Extensions/Models+Parameters.swift 75.00% <75.00%> (ø)
Sources/SteamPress/Extensions/URL+Converters.swift 86.66% <77.77%> (+9.74%) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56851f4...376f57f. Read the comment docs.

@0xTim 0xTim marked this pull request as ready for review April 14, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants