Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect file offsets when exporting PCK #168

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

cgytrus
Copy link
Contributor

@cgytrus cgytrus commented Mar 6, 2024

rn it uses the argument thats passed to the function instead of the local thats actually updated lol
ive tested this change with one game im REing and can confirm that it has fixed my issue

@nikitalita
Copy link
Collaborator

Thanks for the PR! Can you double check that the artifact from the build action fixed the issue?

@cgytrus
Copy link
Contributor Author

cgytrus commented Mar 9, 2024

yep, just tested by extracting the pck then packing it back and using --main-pack to load it, loads fine and everything seems to be working correctly

@nikitalita nikitalita merged commit d180d30 into bruvzg:master Mar 9, 2024
5 checks passed
@nikitalita
Copy link
Collaborator

thank you!

@cgytrus cgytrus deleted the patch-1 branch March 9, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants