Bug 1913500:Add support for PostgreSQL named service connection #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Allow DBI::connect to make the database connection using the PostgreSQL service parameter instead of dbname/dbhost/user/password
Additional info
NOTE: Bug number is required. If you haven't filed a bug on https://bugzilla.mozilla.org/enter_bug.cgi?product=Bugzilla yet, don't submit the Pull Request. Please edit the above link to put the bug number both immediately after the # character and after the = character at the end. You can delete this paragraph once you've added your bug number.
Test Plan
We have an installation of Bugzilla here which only permits connection to the database using the service parameter.
service=.... parameter in the Perl DBI connection code.NOTE: Setting the service in checksetup.pl (new added parameter dbservice), and via the PostgreSQL environment variable PGSERVICE take precedence over the current connection parameters in building the DSN, so the old connection parameters are used if dbservice is not specified in localconfig and if $PGSERVICE is not defined.