Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsuite fixes #45

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

CyberShadow
Copy link
Member

These fix all failures in t/ for me, except for t/901-secure-mail-loop.t.

@dylanwh
Copy link
Member

dylanwh commented Aug 23, 2020

we'll worry about the problems this solves later, as I don't think working on the compile tests is a good use of time.

@dylanwh dylanwh closed this Aug 23, 2020
@dylanwh dylanwh reopened this Oct 2, 2020
@dylanwh
Copy link
Member

dylanwh commented Oct 2, 2020

The other tests are fine, but let's not worry about the 001compile.t tests, those aren't meaningful with the current way code is loaded.

a compile test on bugzilla.pl itself (and only it) could be valid.

@CyberShadow
Copy link
Member Author

@dylanwh OK, this PR is again ready.

I dropped the 001compile.t fixes as discussed. The only argument in favor of keeping that test that I could find was that very occasionally, there are use statements that aren't at the top level, so potentially not every file would be compiled when Bugzilla.pm is loaded, but this didn't seem to be a common enough occurrence to worry about.

I see that ab5ce39 included some of the fixes in this PR (whether cherry-picked or recreated), so I dropped them from here too.

This leaves mojo-oauth2.t, which after re-enabling and one fix is now passing for me, and some warning fixes that weren't affecting whether the test suite is successful or not.

Base automatically changed from master to main February 13, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants