extensions/BugModal: Enable bugzilla-readable-status unconditionally

[CyberShadow]

I see no downside for enabling it always, and let it generate readable descriptions for the "Tracking" section. They appear useful even without the TrackingFlags extension.

This also removes some hard-coded BMO/Firefox-specific logic.

[dylanwh]

Please remove the if (1) { ... } wrapping, that's not needed. I agree with this change other than this small nit.

[CyberShadow]

Done :)

requested chages were made

[justdave]

Do we have a Bugzilla bug that goes with this PR?

[justdave]

Still don't see a bug filed to go with this.
If we hope to keep BMO following upstream in the future, shouldn't we move this code into the BMO extension and add a hook in this spot that it can hook to insert it back?

[CyberShadow]

Sorry, this is part of the BMO cleanup effort, so same bug as most other PRs from me.

[CyberShadow]

If we hope to keep BMO following upstream in the future,

My understanding was that this was never an option, as the BMO team is uninterested in collaborating with any upstream. Has this changed?

[justdave]

My understanding was that this was never an option, as the BMO team is uninterested in collaborating with any upstream.

Yeah, I guess that's pretty much the way it is. They can cherry-pick if they want our stuff. And we'll do the same to theirs in the future.

[justdave]

Sorry, this is part of the BMO cleanup effort, so same bug as most other PRs from me.

OK, so bug 1446236

[justdave]

FYI, this commit broke filing new bugs.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1892558

[justdave]

correction, it broke show_bug, not filing new ones.

[justdave]

This appears to have been missing from the patch: (I made this up based on the usage, but it seems to work)

diff --git a/Bugzilla.pm b/Bugzilla.pm
index e58d84f32..06aa3fb0a 100644
--- a/Bugzilla.pm
+++ b/Bugzilla.pm
@@ -135,6 +135,12 @@ sub extensions {
   return $extensions;
 }

+sub has_extension {
+  my (undef, $extension) = @_;
+  return 1 if (grep { $_ eq $extension } Bugzilla->extensions);
+  return 0;
+}
+
 sub cgi {
   return request_cache->{cgi} ||= Bugzilla::CGI->new;
 }

However, that leads to:

Odd number of elements in anonymous hash at /app/extensions/BugModal/Extension.pm line 209.

I don't think this was ready to land.