Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use detached spawn for agent #5

Merged
merged 43 commits into from
Dec 4, 2023
Merged

feat: use detached spawn for agent #5

merged 43 commits into from
Dec 4, 2023

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Dec 1, 2023

Summary

Adds functionality to detect and use an existing agent, if available. Adds several unit tests, and shifts to spawning the agent via a detached child process rather than calling buildless agent start.

Changelog

  • feat: detect and use existing agent ("unmanaged" mode)
  • fix: prepare temp paths before installation
  • test: significant improvement in test coverage

- feat: detect and use existing agent ("unmanaged" mode)
- fix: prepare temp paths before installation
- test: significant improvement in test coverage

Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon added the enhancement New feature or request label Dec 1, 2023
@sgammon sgammon self-assigned this Dec 1, 2023
@sgammon sgammon force-pushed the feat/existing-agent branch 10 times, most recently from 5b6fa90 to b603405 Compare December 1, 2023 23:09
Copy link

codecov bot commented Dec 2, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon marked this pull request as ready for review December 4, 2023 07:18
Copy link

sonarcloud bot commented Dec 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 26 Code Smells

32.9% 32.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sgammon sgammon merged commit 678e022 into main Dec 4, 2023
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant