remove findDOMNode usage in Table component #1856
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The React
findDOMNode()
API has been deprecated since 2018 and will be removed in React 19, the next major version. This PR removesfindDOMNode
usage from theTable
component for compatibility with Strict Mode and to move towards React 19 compatibility. TheWindowScroller
andCellMeasurer
components also usefindDOMNode()
but have existing workaround by using theregisterChild
from the render callback.My solution in this PR was to add a
getDOMNode
method on theGrid
class and call that fromTable
. An alternative I considered is to add a new refdomNodeRef
toTable
and use that to get the reference.Before submitting a pull request, please complete the following checklist:
npm test
) all passyarn run prettier
).yarn run typecheck
).