Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fiat rate on receive screen. #1754

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

konstantinullrich
Copy link
Contributor

Description

This fixes a divide with 0 issue on the receive screen

Testing

Please test for the following:
Go to the receive screen and select a fiat currency other than your default.
Now enter a amount and scan the QR code with a other wallet. The fiat value of the amount encoded should correspond with the fiat value entered.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

Copy link
Contributor

@OmarHatem28 OmarHatem28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many reformatting changes for just a small change
let's make the reformatting in a separate PR in future instances

and let's handle the case we discussed about entering the amount then selecting the currency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants