Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fct_daily_trip_update_status_counts key is just URL and trip ID but group by includes GTFS dataset key #2803

Closed
lauriemerrell opened this issue Jul 14, 2023 · 1 comment · Fixed by #2804
Closed

fct_daily_trip_update_status_counts key is just URL and trip ID but group by includes GTFS dataset key #2803

lauriemerrell opened this issue Jul 14, 2023 · 1 comment · Fixed by #2804

Comments

@lauriemerrell
Copy link
Contributor

See: https://github.com/cal-itp/data-infra/blob/main/warehouse/models/mart/ad_hoc/fct_daily_trip_update_status_counts.sql#L16-L25 -- we test uniqueness of a key that doesn't include GTFS dataset key but GTFS dataset key is included in the group by.

Sentry Issue: CAL-ITP-DATA-INFRA-268T

This model should also be migrated to use service_date instead of dt post #2489.
@cal-itp-sentry
Copy link

Sentry issue: CAL-ITP-DATA-INFRA-268T

@lauriemerrell lauriemerrell changed the title 1fct_daily_trip_update_status_counts key` is just URL and trip ID but group by includes GTFS dataset key fct_daily_trip_update_status_counts key is just URL and trip ID but group by includes GTFS dataset key Jul 14, 2023
@lauriemerrell lauriemerrell mentioned this issue Jul 17, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup post #2489 cal-itp/data-infra
1 participant
@lauriemerrell