-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup post #2489 #2804
Merged
Merged
Cleanup post #2489 #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atvaccaro
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed offline
lauriemerrell
added
do-not-merge
Do not merge, even if approved
and removed
do-not-merge
Do not merge, even if approved
labels
Jul 17, 2023
dbt run / test (unqualified) passed with no new failures (all failures predate #2489). Merging and kicking off full refresh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes and why you're making them. Please include the context, motivation, and relevant dependencies.
Resolves a whole bunch of issues that popped up after #2489 merged, primarily because of the larger time period of data covered in the full refresh compared to test data.
Specifically, this PR:
fct_daily_schedule_feeds
for RT/schedule mapping for cases where the GTFS schedule URL changes and RT data is scraped before the GTFS schedule download occurs. This was indirectly causing CAL-ITP-DATA-INFRA-268M, CAL-ITP-DATA-INFRA-268R, and CAL-ITP-DATA-INFRA-2685 because of insufficient handling for multiple schedule URLs on the samedt
/service date
schedule_base64_url
to the intermediate table keys; this may help with some of the duplicates that were observed (cases where a key was duplicated because the same trip occurred across two schedule URL versions)fct_daily_trip_update_status_counts
model that was erroring and (per Slack) is ok to deleteResolves #2802
Resolves #2803
Type of change
How has this been tested?
Include commands/logs/screenshots as relevant.
Ran all affected tables and tested them and downstream models.
Doing an unqualified run & test right now to confirm none of the fixed issues are present
Post-merge follow-ups
Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.
+fct_trip_updates_messages+ +fct_vehicle_positions_messages+ +fct_service_alerts_messages+
to get the fixed keying