Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add active period start/end timestamp columns and cleanup yaml #2590

Merged
merged 1 commit into from
May 12, 2023

Conversation

lauriemerrell
Copy link
Contributor

Description

Describe your changes and why you're making them. Please include the context, motivation, and relevant dependencies.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Include commands/logs/screenshots as relevant.

Full refreshed fct_service_alerts_messages_unnested and confirmed new columns appear and seem reasonable. New test passes and I looked at the executed SQL and confirmed that __rt_sampled__ is compiling as expected.

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

@github-actions
Copy link

Warehouse report 📦

New models 🌱

mart.gtfs.fct_service_alerts_messages_unnested
intermediate.gtfs.int_gtfs_rt__service_alerts_fully_unnested

Changed models 🔀

mart.transit_database.dim_organizations
mart.payments.elavon_littlepay__daily_history_transactions_deposits_billing
mart.gtfs.fct_daily_service_alerts
mart.gtfs.fct_service_alerts_trip_summaries

@lauriemerrell lauriemerrell merged commit e800895 into main May 12, 2023
@lauriemerrell lauriemerrell deleted the active-period-ts-service-alerts branch May 12, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants