-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate CI to use python invoke #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atvaccaro
force-pushed
the
python-ci
branch
4 times, most recently
from
June 22, 2023 19:58
6f79c90
to
deceefa
Compare
atvaccaro
changed the title
tinkering with CI in python
migrate CI to use python invoke
Jun 22, 2023
atvaccaro
added
do-not-merge
Do not merge, even if approved
and removed
do-not-merge
Do not merge, even if approved
labels
Jun 22, 2023
atvaccaro
requested review from
charlie-costanzo and
lauriemerrell
as code owners
June 23, 2023 16:07
lottspot
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great leap forward!
lauriemerrell
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty superficial comments, feel free to take or leave it. Except a few typos that should just be cleaned up
lauriemerrell
approved these changes
Jun 26, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes and why you're making them. Please include the context, motivation, and relevant dependencies.
Resolves #2670
I'm finding myself having to resolve conflicts between candidate and releases branches occasionally, but I haven't dug into the git commands yet (that's next, at minimum just to understand them).
Marking as do-not-merge while I update the docs.I'm also working on an architecture diagram, but that doesn't block this.Type of change
How has this been tested?
Include commands/logs/screenshots as relevant.
I've deployed to test.
Post-merge follow-ups
Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.
Deploy to prod.