Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate CI to use python invoke #2736

Merged
merged 56 commits into from
Jun 26, 2023
Merged

migrate CI to use python invoke #2736

merged 56 commits into from
Jun 26, 2023

Conversation

atvaccaro
Copy link
Contributor

@atvaccaro atvaccaro commented Jun 20, 2023

Description

Describe your changes and why you're making them. Please include the context, motivation, and relevant dependencies.

Resolves #2670

I'm finding myself having to resolve conflicts between candidate and releases branches occasionally, but I haven't dug into the git commands yet (that's next, at minimum just to understand them).

Marking as do-not-merge while I update the docs. I'm also working on an architecture diagram, but that doesn't block this.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Include commands/logs/screenshots as relevant.

I've deployed to test.

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

  • No action required
  • Actions required (specified below)
    Deploy to prod.

@atvaccaro atvaccaro mentioned this pull request Jun 20, 2023
6 tasks
@atvaccaro atvaccaro changed the title start tinkering with invoke tinkering with CI in python Jun 20, 2023
@atvaccaro atvaccaro force-pushed the python-ci branch 4 times, most recently from 6f79c90 to deceefa Compare June 22, 2023 19:58
@atvaccaro atvaccaro self-assigned this Jun 22, 2023
@atvaccaro atvaccaro changed the title tinkering with CI in python migrate CI to use python invoke Jun 22, 2023
@atvaccaro atvaccaro marked this pull request as ready for review June 22, 2023 21:28
@atvaccaro atvaccaro added do-not-merge Do not merge, even if approved and removed do-not-merge Do not merge, even if approved labels Jun 22, 2023
@atvaccaro atvaccaro removed the do-not-merge Do not merge, even if approved label Jun 23, 2023
Copy link
Contributor

@lottspot lottspot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great leap forward!

ci/invoke.yaml Outdated Show resolved Hide resolved
ci/tasks.py Outdated Show resolved Hide resolved
ci/tasks.py Outdated Show resolved Hide resolved
.github/workflows/service-release-diff.yml Outdated Show resolved Hide resolved
.github/workflows/service-release-diff.yml Outdated Show resolved Hide resolved
.github/workflows/service-release-diff.yml Outdated Show resolved Hide resolved
@atvaccaro atvaccaro requested a review from lottspot June 23, 2023 20:14
@github-actions
Copy link

Copy link
Contributor

@lauriemerrell lauriemerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty superficial comments, feel free to take or leave it. Except a few typos that should just be cleaned up

docs/infrastructure/README.md Outdated Show resolved Hide resolved
ci/tasks.py Outdated Show resolved Hide resolved
ci/tasks.py Outdated Show resolved Hide resolved
ci/tasks.py Show resolved Hide resolved
ci/tasks.py Show resolved Hide resolved
ci/tasks.py Outdated Show resolved Hide resolved
ci/tasks.py Show resolved Hide resolved
docs/infrastructure/README.md Outdated Show resolved Hide resolved
docs/infrastructure/README.md Outdated Show resolved Hide resolved
@atvaccaro atvaccaro merged commit 5409fb1 into main Jun 26, 2023
5 checks passed
@atvaccaro atvaccaro deleted the python-ci branch June 26, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up doit-based deploy CI for one application
3 participants