Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start on new infra/arch docs #2767

Merged
merged 8 commits into from
Jul 11, 2023
Merged

start on new infra/arch docs #2767

merged 8 commits into from
Jul 11, 2023

Conversation

atvaccaro
Copy link
Contributor

@atvaccaro atvaccaro commented Jun 26, 2023

Description

Describe your changes and why you're making them. Please include the context, motivation, and relevant dependencies.

Resolves #2672

Creates a couple of high-level architecture diagrams and adds some additional service/environment docs. Should set us up for service/folder-specific READMEs in the next sprint.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Include commands/logs/screenshots as relevant.

see docs preview

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

  • No action required
  • Actions required (specified below)

@atvaccaro atvaccaro self-assigned this Jun 26, 2023
@github-actions
Copy link

Copy link
Contributor

@lauriemerrell lauriemerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, the text all looks good but the data flow diagram is pretty funky now. I think that the old one was doing some stuff vis a vis styling and grouping that you need to account for a bit more.

docs/architecture/architecture_overview.md Show resolved Hide resolved
@atvaccaro atvaccaro merged commit e9298fb into main Jul 11, 2023
4 checks passed
@atvaccaro atvaccaro deleted the infra-docs branch July 11, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-implement high level architecture diagram in mermaid.js in the repo
2 participants