Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update publication script so that it doesn't rely on _latest models #2779

Closed
wants to merge 2 commits into from

Conversation

SorenSpicknall
Copy link
Contributor

Description

Once ready, this PR will removes the _latest models from the path to open data publication, relying instead on dynamic generation of the required CSV files via a recreation of the effect of the get_latest_schedule_data macro inside the publication script.

Resolves #2701

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Not thoroughly tested at the time of WIP PR creation

Post-merge follow-ups

  • No action required
  • Actions required (specified below)
    After we merge this and ensure it works as expected in prod, we can deprecate the _latest models via our regular stepped-in deprecation process.

@SorenSpicknall
Copy link
Contributor Author

Closing because this work was deprioritized in July while incomplete. If somebody picks up the same Issue in the future, they'll likely want to do so from a fresh branch.

@SorenSpicknall SorenSpicknall deleted the soren-publish_without_latest_models branch December 12, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move open data publishing out of models, and into where-clause logic
1 participant