Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ntd_id_2022 using airtable #3367

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Updating ntd_id_2022 using airtable #3367

merged 1 commit into from
Jun 11, 2024

Conversation

vevetron
Copy link
Contributor

@vevetron vevetron commented Jun 7, 2024

Description

In a previous #3364 PR a formula was used to generate ntd_id_2022, but it's better to put it in airtable. This way joins from airtable table have this id available easily especially when one might want to join to other more recent ntd data.

Separately using a csv join ntd_id_2022 was calculated and added to the orgs table. This also removes that calculation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

local airflow

poetry run dbt run -s +dim_organizations

Post-merge follow-ups

  • No action required

Copy link

github-actions bot commented Jun 7, 2024

Warehouse report 📦

DAG

Legend (in order of precedence)

Resource type Indicator Resolution
Large table-materialized model Orange Make the model incremental
Large model without partitioning or clustering Orange Add partitioning and/or clustering
View with more than one child Yellow Materialize as a table or incremental
Incremental Light green
Table Green
View White

@vevetron vevetron marked this pull request as ready for review June 11, 2024 17:44
Copy link
Member

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking to #3366 to capture relevant conversation that this is what the team has aligned on.

@vevetron vevetron merged commit 329b926 into main Jun 11, 2024
4 checks passed
@vevetron vevetron deleted the refixing_ntd_id_2022 branch June 11, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants