Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review 2022 NTD external tables columns #3479

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

erikamov
Copy link
Contributor

[#3403]

Description

Review NTD 2022 external tables data types based on the official documentation, and added some missing optional columns.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Tested running Airflow locally.

Post-merge follow-ups

  • No action required
  • Actions required (specified below)

Check the next execution of the create_external_tables DAG to see if all tables were created successfully.

Copy link
Member

@charlie-costanzo charlie-costanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for taking care of this Erika!

@erikamov erikamov merged commit 968dcfa into main Sep 26, 2024
1 check passed
@erikamov erikamov deleted the 3403-review-2022-ntd-columns branch September 26, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants