Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch service date for activity date #246

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

lauriemerrell
Copy link
Contributor

@lauriemerrell lauriemerrell commented Apr 21, 2023

Description

🚨 This is blocked by cal-itp/data-infra#2457

Go back to service_date for graphs.

Resolves #245

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Would appreciate guidance from @charlie-costanzo on how best to test -- so far, I ran data generation in docker and confirmed it all worked

Screenshots (optional)

@lauriemerrell lauriemerrell marked this pull request as ready for review April 24, 2023 13:57
Copy link
Member

@charlie-costanzo charlie-costanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for taking care of this!

@lauriemerrell lauriemerrell merged commit 2459232 into main Apr 25, 2023
@lauriemerrell lauriemerrell deleted the use-service-date branch April 25, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates from activity_date to service_date change in organization service summary
2 participants