Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix find_column_type utility method #225

Closed
wants to merge 2 commits into from

Conversation

rhaffar
Copy link
Contributor

@rhaffar rhaffar commented Aug 29, 2023

  • Updated find_column_type method to only map columns types to date if they contain data with valid Snowflake date formats
  • Added warehouse parameter to find_column_type method to differentiate column type mappings based on warehouse type (only affects dates)
  • Updated test and internal calls of find_column_type

*Apologies for the delay, had to wait for appropriate permissions to make public github contributions

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ rhaffar
❌ ekn111


ekn111 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fdosani
Copy link
Member

fdosani commented Aug 29, 2023

@rhaffar you will need to sign the CLA. Not sure but you might have a leak with the second user. FYI.

@rhaffar
Copy link
Contributor Author

rhaffar commented Aug 29, 2023

@rhaffar you will need to sign the CLA. Not sure but you might have a leak with the second user. FYI.

Ah yeah, I'll address that and open a separate PR.

@rhaffar rhaffar closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants