Dataframe name #472
Draft
Dataframe name #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aframe Plot visualizations
…ng Metric List Comparison visualizations
…to metric-list
…son in publish.py
…the first experiment's dataframe
| @@ -43,17 +43,22 @@ class DataframePlot(VizBase): | |||
|
|
|||
| def __init__( | |||
| self, | |||
| dataframe_name, | |||
| dataframe_name=None, | |||
There was a problem hiding this comment.
Can we please add type hints as we go through these? Thanks.
|
Is this PR dependent on #471 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #469
Issue
An error is raised whenever a dataframe is created without a
dataframe_nameparameter. Visualizations should be able to be instantiated without any arguments other than their experiments.Changes
Updated
dataframe_plot.pyto defaultdataframe_nametoNone. If nodataframe_nameis passed in, then thedataframe_nameis set to the name of the dataframe logged to the the first experiment.