Secure Communication Channels via TLS #75
Conversation
Signed-off-by: Benjamin Hettwer <[email protected]>
Signed-off-by: Benjamin Hettwer <[email protected]>
Signed-off-by: Benjamin Hettwer <[email protected]>
Signed-off-by: Benjamin Hettwer <[email protected]>
Signed-off-by: Benjamin Hettwer <[email protected]>
Signed-off-by: Benjamin Hettwer <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 82.29% 80.81% -1.48%
==========================================
Files 29 29
Lines 3158 3248 +90
==========================================
+ Hits 2599 2625 +26
- Misses 485 544 +59
- Partials 74 79 +5
Flags with carried forward coverage won't be shown. Click here to find out more. see 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Benjamin Hettwer <[email protected]>
Signed-off-by: Benjamin Hettwer <[email protected]>
| {{- if .Values.discovery.tls.enabled }} | ||
| - port: | ||
| number: 31400 | ||
| name: grpc-my |
There was a problem hiding this comment.
hmm I know it was named grpcy-my before, but eventually rename to sth like cs-grpc here and below
pkg/ephemeral/io/feeder.go
Outdated
There was a problem hiding this comment.
as file was touched either update copyright header or undo changes 😉
pkg/ephemeral/network/proxy.go
Outdated
| @@ -167,9 +170,14 @@ func (r *ReconcileNetwork) Reconcile(request reconcile.Request) (reconcile.Resul | |||
| return reconcile.Result{}, err | |||
| } | |||
|
|
|||
| log.Info(fmt.Sprintf("Reconcile with the config:\n%+v", r.config)) | |||
| if err != nil { | |||
There was a problem hiding this comment.
why checking error and panic? err was already checked before, wasn't it?
pkg/types/types.go
Outdated
| @@ -137,6 +154,13 @@ type DiscoveryClientTypedConfig struct { | |||
| ConnectTimeout time.Duration | |||
| } | |||
|
|
|||
| // K8sSecret represents the structure containing key, cert, and CA cert | |||
| type K8sSecret struct { | |||
pkg/utils/os.go
Outdated
|
@benjaminhettwer btw. please add yourself to the NOTICE.md file |
Signed-off-by: Benjamin Hettwer <[email protected]>
No description provided.