Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fonts #324

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Conversation

fmichonneau
Copy link
Contributor

This addresses #168.

In addition to using Ubuntu for the font of the text, I kept the default font for the navigation and the footer, tweaked slightly the size of the fonts, and use Lato for the headers.

Before:
screenshot from 2018-07-03 16-38-30

After:
screenshot from 2018-07-03 16-38-44

@maxim-belkin
Copy link
Contributor

maxim-belkin commented Jul 3, 2018

This implementation lacks bold/italics/bold italics variants of Ubuntu. Also, TBH, I'm not sure I like Lato font more than Ubuntu for titles.

Here is a CSS I created for my other project. For that, I had to download Ubuntu fonts from here, unpack them, and create that CSS. It defines Ubuntu and Ubuntu Mono.

@rgaiacs
Copy link
Contributor

rgaiacs commented Jul 4, 2018

In addition to using Ubuntu for the font of the text, I kept the default font for the navigation and the footer, tweaked slightly the size of the fonts, and use Lato for the headers.

Why keep the font for navigation and use another for headers? My reading of your sentence is "navigation and headers are second class citizens in our lesson that don't need to be accessible to everyone."

@rgaiacs
Copy link
Contributor

rgaiacs commented Aug 15, 2018

@fmichonneau any update on this one?

@fmichonneau
Copy link
Contributor Author

The Carpentries remote theme uses Ubuntu (and has done so since May 2019). I haven't heard compliments or complaints about it. Maybe it's time to bring this proposed change to the maintainers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:in progress Contributor working on issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants