case_validate: Default inference flag to None rather than "none" #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaulting to the string `"none"` has a functional consequence in downstream pySHACL operations, as encoded at the time of this writing (pySHACL version 0.23.0). `inference` in the `pyshacl.validate(...)` arguments is propagated down two code paths that both impact the validation operation, but that use different default values. The `--metashacl` (SHACL-SHACL validation graph for reviewing shape syntax)- aligned code path defaults to `rdfs` inference, and the `Validator` class defaults to the string `"none"`. Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
changed the title
Merged
kchason
approved these changes
Aug 23, 2023
ajnelson-nist
added a commit
that referenced
this pull request
Aug 23, 2023
…n "none" This is a continuation of PR 123. References: * #123 Signed-off-by: Alex Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaulting to the string
"none"has a functional consequence in downstream pySHACL operations, as encoded at the time of this writing (pySHACL version 0.23.0).inferencein thepyshacl.validate(...)arguments is propagated down two code paths that both impact the validation operation, but that use different default values. The--metashacl(SHACL-SHACL validation graph for reviewing shape syntax)- aligned code path defaults tordfsinference, and theValidatorclass defaults to the string"none".